more unit tests working.

imgui drawing directly to background now
This commit is contained in:
Trevor Merritt 2024-10-30 12:00:33 -04:00
parent 011874bca6
commit d8b14fa084
10 changed files with 506 additions and 383 deletions

File diff suppressed because one or more lines are too long

View File

@ -18,7 +18,7 @@ y - A 4-bit value, the upper 4 bits of the low byte of the instruction
kk or byte - An 8-bit value, the lowest 8 bits of the instruction
*/
#[derive(Debug)]
#[derive(Debug, Clone)]
pub enum Chip8CpuInstructions {
/// 0nnn
/// Exit to System Call at nnn
@ -222,26 +222,26 @@ pub enum Chip8CpuInstructions {
LDRI(u8),
XXXXERRORINSTRUCTION,
/* START OF SCHIP-8 */
/// 00CN
/// 00CN - CHIP8 * SCHIP * XOCHIP
///
/// Scrolll Display N Lines Down
SDN(u8),
SCD(u8),
/// 00FB
///
/// Scroll 4 lines Right
SRT,
SCR,
/// 00FC
///
/// Scroll 4 lines Left
SLF,
SCL,
/// 00FE
///
/// Disable Extended Mode
DIS,
LOW,
/// 00FF
///
/// Enable Extended Mode
ENA,
HIGH,
/// 00FD
///
/// Exit App
@ -293,9 +293,9 @@ impl Chip8CpuInstructions {
Chip8CpuInstructions::OR(_, _) => INST_OR,
Chip8CpuInstructions::RET => INST_RET,
Chip8CpuInstructions::RND(_, _) => INST_RND,
Chip8CpuInstructions::SDN(_) => INST_SDN,
Chip8CpuInstructions::SLF => INST_SLF,
Chip8CpuInstructions::SRT => INST_SRT,
Chip8CpuInstructions::SCD(_) => INST_SCD,
Chip8CpuInstructions::SCL => INST_SCL,
Chip8CpuInstructions::SCR => INST_SCR,
Chip8CpuInstructions::SEX(_, _) => INST_SEX,
Chip8CpuInstructions::SEY(_, _) => INST_SEY,
Chip8CpuInstructions::SHL(_, _) => INST_SHL,
@ -308,8 +308,8 @@ impl Chip8CpuInstructions {
Chip8CpuInstructions::SUB(_, _) => INST_SUB,
Chip8CpuInstructions::SUBC(_, _) => INST_SUBC,
Chip8CpuInstructions::SYS(_) => INST_SYS,
Chip8CpuInstructions::DIS => INST_DIS,
Chip8CpuInstructions::ENA => INST_ENA,
Chip8CpuInstructions::LOW => INST_LOW,
Chip8CpuInstructions::HIGH => INST_HIGH,
Chip8CpuInstructions::ORY(_, _) => INST_ORY,
JPX(_, _) => INST_JPX,
XXXXERRORINSTRUCTION => "XX ERROR XX",
@ -319,7 +319,8 @@ impl Chip8CpuInstructions {
pub fn operands(&self) -> String {
match self {
JPX(x, addr) => {
format!("0x{x:02x}, 0x{addr:04x}")
let addr_for_display = (*x as u16 ) << 8 | *addr;
format!("0x{x:02x}, 0x{addr_for_display:04x}")
}
Chip8CpuInstructions::SYS(addr) |
Chip8CpuInstructions::JPI(addr) |
@ -366,17 +367,17 @@ impl Chip8CpuInstructions {
Chip8CpuInstructions::LDF2(x) |
Chip8CpuInstructions::STR(x) |
Chip8CpuInstructions::LIDR(x) |
Chip8CpuInstructions::SDN(x) |
Chip8CpuInstructions::SCD(x) |
Chip8CpuInstructions::SKNP(x) |
Chip8CpuInstructions::SKP(x) => {
format!("0x{x:02x}")
}
Chip8CpuInstructions::EXIT |
Chip8CpuInstructions::ENA |
Chip8CpuInstructions::DIS |
Chip8CpuInstructions::SLF |
Chip8CpuInstructions::HIGH |
Chip8CpuInstructions::LOW |
Chip8CpuInstructions::SCL |
Chip8CpuInstructions::XXXXERRORINSTRUCTION |
Chip8CpuInstructions::SRT |
Chip8CpuInstructions::SCR |
Chip8CpuInstructions::CLS |
Chip8CpuInstructions::RET => {
String::new()
@ -406,15 +407,18 @@ impl Chip8CpuInstructions {
let param3 = u16::from_str_radix(parts.next().unwrap_or("0").trim_start_matches("0x").trim_end_matches(","), 16).unwrap_or(0);
// println!("\tFirst part is {:?} / {:?} / {:?} / {:?}", first_part, param1 ,param2 ,param3);
match first_part {
INST_ADDI => {
ADDI(param1 as u8)
}
INST_ADD => {
ADD(param1 as u8, param2 as u8)
}
INST_CLS => {
CLS
}
INST_DRW => {
DRW(param1 as u8, param2 as u8, param3 as u8)
}
INST_ADD => {
ADD(param1 as u8, param2 as u8)
}
INST_CALL => {
CALL(param1)
}
@ -436,23 +440,23 @@ impl Chip8CpuInstructions {
INST_SNEB => {
SNEB(param1 as u8, param2 as u8)
}
INST_SDN => {
SDN(param1 as u8)
INST_SCD => {
SCD(param1 as u8)
}
INST_SRT => {
SRT
INST_STR => {
STR(param1 as u8)
}
INST_SLF => {
SLF
INST_SCL => {
SCL
}
INST_EXIT => {
EXIT
}
INST_DIS => {
DIS
INST_LOW => {
LOW
}
INST_ENA => {
ENA
INST_HIGH => {
HIGH
}
INST_SEY => {
SEY(param1 as u8, param2 as u8)
@ -568,7 +572,7 @@ impl Chip8CpuInstructions {
Chip8CpuInstructions::SNEY(x_register, y_register) => 0x9000 | ((*x_register as u16) << 8) | ((*y_register as u16) << 4),
Chip8CpuInstructions::LDIA(addr) => 0xA000 | addr,
Chip8CpuInstructions::JPI(addr) => 0xB000 | addr,
JPX(x_register, addr)=> 0xB000u16 | ((*x_register as u16) << 12) | *addr ,
JPX(x_register, addr)=> (0xb000 | (*x_register as u16) << 8) | *addr,
Chip8CpuInstructions::RND(x_register, byte) => 0xC000 | ((*x_register as u16) << 8) | (*byte as u16),
Chip8CpuInstructions::DRW(x_register, y_register, height) => {
0xD000 | ((*x_register as u16) << 8) | ((*y_register as u16) << 4) | (*height as u16)
@ -584,11 +588,11 @@ impl Chip8CpuInstructions {
Chip8CpuInstructions::BCD(x_register) => 0xF033 | ((*x_register as u16) << 8),
Chip8CpuInstructions::LDIX(x_register) => 0xF055 | ((*x_register as u16) << 8),
Chip8CpuInstructions::LDRI(x_register) => 0xF065 | ((*x_register as u16) << 8),
Chip8CpuInstructions::SDN(x_register) => 0x00C0 | (*x_register as u16),
Chip8CpuInstructions::SRT => 0x00FB,
Chip8CpuInstructions::SLF => 0x00FC,
Chip8CpuInstructions::DIS => 0x00FE,
Chip8CpuInstructions::ENA => 0x00FF,
Chip8CpuInstructions::SCD(x_register) => 0x00C0 | (*x_register as u16),
Chip8CpuInstructions::SCR => 0x00FB,
Chip8CpuInstructions::SCL => 0x00FC,
Chip8CpuInstructions::LOW => 0x00FE,
Chip8CpuInstructions::HIGH => 0x00FF,
Chip8CpuInstructions::EXIT => 0x00FD,
Chip8CpuInstructions::LDF2(x_register) => 0xF030 | ((*x_register as u16) << 8),
Chip8CpuInstructions::STR(x_register) => 0xF075 | ((*x_register as u16) << 8),
@ -613,10 +617,10 @@ impl Chip8CpuInstructions {
XXXXERRORINSTRUCTION
}
QuirkMode::XOChip => {
SDN(last_nibble)
SCD(last_nibble)
}
QuirkMode::SChipModern => {
SDN(last_nibble)
SCD(last_nibble)
}
}
},
@ -629,25 +633,54 @@ impl Chip8CpuInstructions {
XXXXERRORINSTRUCTION
}
QuirkMode::XOChip => {
Chip8CpuInstructions::SRT
Chip8CpuInstructions::SCR
}
QuirkMode::SChipModern => {
Chip8CpuInstructions::SRT
Chip8CpuInstructions::SCR
}
}
},
0x00FC => Chip8CpuInstructions::SLF,
0x00FC => Chip8CpuInstructions::SCL,
0x00FD => Chip8CpuInstructions::EXIT,
0x00FE => Chip8CpuInstructions::DIS,
0x00FF => Chip8CpuInstructions::ENA,
0x0000..=0x0FFF => Chip8CpuInstructions::SYS(addr_param),
0x1000..=0x1FFF => Chip8CpuInstructions::JPA(addr_param),
0x2000..=0x2FFF => Chip8CpuInstructions::CALL(addr_param),
0x3000..=0x3FFF => Chip8CpuInstructions::SEX(x_param, byte_param),
0x4000..=0x4FFF => Chip8CpuInstructions::SNEB(x_param, byte_param),
0x5000..=0x5FF0 if input & 0x01 == 0 => Chip8CpuInstructions::SEY(x_param, y_param),
0x6000..=0x6FFF => Chip8CpuInstructions::LDR(x_param, byte_param),
0x7000..=0x7FFF => Chip8CpuInstructions::ADD(x_param, byte_param),
0x00FE => {
match quirk_mode {
QuirkMode::Chip8 => {
XXXXERRORINSTRUCTION
}
QuirkMode::XOChip |
QuirkMode::SChipModern => {
LOW
}
}
},
0x00FF => {
match quirk_mode {
QuirkMode::Chip8 => {
XXXXERRORINSTRUCTION
},
QuirkMode::XOChip |
QuirkMode::SChipModern => {
HIGH
}
}
},
0x0000..=0x0FFF => {
match quirk_mode {
QuirkMode::Chip8 => {
Chip8CpuInstructions::SYS(addr_param)
}
QuirkMode::XOChip | QuirkMode::SChipModern => {
XXXXERRORINSTRUCTION
}
}
},
0x1000..=0x1FFF => JPA(addr_param),
0x2000..=0x2FFF => CALL(addr_param),
0x3000..=0x3FFF => SEX(x_param, byte_param),
0x4000..=0x4FFF => SNEB(x_param, byte_param),
0x5000..=0x5FF0 if input & 0x01 == 0 => SEY(x_param, y_param),
0x6000..=0x6FFF => LDR(x_param, byte_param),
0x7000..=0x7FFF => ADD(x_param, byte_param),
0x8000..=0x8FFE => match last_nibble {
0x0 => Chip8CpuInstructions::LDR_Y(x_param, y_param),
0x1 => Chip8CpuInstructions::OR(x_param, y_param),
@ -1088,19 +1121,36 @@ impl Chip8CpuInstructions {
input.registers.poke_i(offset + 1);
}
Chip8CpuInstructions::XXXXERRORINSTRUCTION => {}
Chip8CpuInstructions::SDN(x) => {
input.video_memory.scroll_down(*x as i32);
Chip8CpuInstructions::SCD(x) => {
match input.quirk_mode {
QuirkMode::Chip8 => {
panic!("Attempt to execute SCD in Chip8 Mode");
}
Chip8CpuInstructions::SRT => {
QuirkMode::XOChip |
QuirkMode::SChipModern => {
input.video_memory.scroll_down(*x as i32);
}
}
}
Chip8CpuInstructions::SCR => {
match input.quirk_mode {
QuirkMode::Chip8 => {
// panic!("Attempt to execute SCR in Chip8 Mode");
}
QuirkMode::XOChip |
QuirkMode::SChipModern => {
input.video_memory.scroll_right();
}
Chip8CpuInstructions::SLF => {
}
}
Chip8CpuInstructions::SCL => {
input.video_memory.scroll_left();
}
Chip8CpuInstructions::DIS => {
Chip8CpuInstructions::LOW => {
input.video_memory.set_lowres();
}
Chip8CpuInstructions::ENA => {
Chip8CpuInstructions::HIGH => {
input.video_memory.set_highres();
}
Chip8CpuInstructions::EXIT => {

View File

@ -46,9 +46,9 @@ pub const INST_LDRY: &str = "LDRY";
pub const INST_OR: &str = "OR";
pub const INST_RET: &str = "RET";
pub const INST_RND: &str = "RND";
pub const INST_SDN: &str = "SDN";
pub const INST_SRT: &str = "SRT";
pub const INST_SLF: &str = "SLF";
pub const INST_SCD: &str = "SCD";
pub const INST_SCR: &str = "SCR";
pub const INST_SCL: &str = "SCL";
pub const INST_SEX: &str = "SEX";
pub const INST_SEY: &str = "SEY";
pub const INST_SHL: &str = "SHL";
@ -61,8 +61,8 @@ pub const INST_STR: &str = "STR";
pub const INST_SUB: &str = "SUB";
pub const INST_SUBC: &str = "SUBC";
pub const INST_SYS: &str = "SYS";
pub const INST_DIS: &str = "DIS";
pub const INST_ENA: &str = "ENA";
pub const INST_LOW: &str = "LOW";
pub const INST_HIGH: &str = "HIGH";
pub const INST_ORY: &str = "ORY";
pub const CHIP8_PROGRAM_LOAD_OFFSET: i32 = 0x200;

View File

@ -61,12 +61,12 @@ fn encode_decode_test() {
assert_eq!(Chip8CpuInstructions::BCD(0xd).encode(), 0xfd33);
assert_eq!(Chip8CpuInstructions::LDIX(0xe).encode(), 0xfe55);
assert_eq!(Chip8CpuInstructions::LDRI(0x3).encode(), 0xf365);
assert_eq!(Chip8CpuInstructions::SDN(0x1).encode(), 0x00C1);
assert_eq!(Chip8CpuInstructions::SLF.encode(), 0x00FC);
assert_eq!(Chip8CpuInstructions::SRT.encode(), 0x00FB);
assert_eq!(Chip8CpuInstructions::SCD(0x1).encode(), 0x00C1);
assert_eq!(Chip8CpuInstructions::SCL.encode(), 0x00FC);
assert_eq!(Chip8CpuInstructions::SCR.encode(), 0x00FB);
assert_eq!(Chip8CpuInstructions::EXIT.encode(), 0x00FD);
assert_eq!(Chip8CpuInstructions::ENA.encode(), 0x00FF);
assert_eq!(Chip8CpuInstructions::DIS.encode(), 0x00FE);
assert_eq!(Chip8CpuInstructions::HIGH.encode(), 0x00FF);
assert_eq!(Chip8CpuInstructions::LOW.encode(), 0x00FE);
assert_eq!(Chip8CpuInstructions::LDF2(0).encode(), 0xF030);
assert_eq!(Chip8CpuInstructions::STR(1).encode(), 0xF175);
assert_eq!(Chip8CpuInstructions::LIDR(1).encode(), 0xF185);
@ -1343,11 +1343,11 @@ fn instructions_operands_tests() {
fn instruction_ena_dis_tests() {
let mut x = Chip8Computer::new();
assert!(!x.video_memory.is_highres());
Chip8CpuInstructions::ENA.execute(&mut x);
Chip8CpuInstructions::HIGH.execute(&mut x);
assert!(x.video_memory.is_highres());
Chip8CpuInstructions::ENA.execute(&mut x);
Chip8CpuInstructions::HIGH.execute(&mut x);
assert!(x.video_memory.is_highres());
Chip8CpuInstructions::DIS.execute(&mut x);
Chip8CpuInstructions::LOW.execute(&mut x);
assert!(!x.video_memory.is_highres());
}
@ -1355,24 +1355,24 @@ fn instruction_ena_dis_tests() {
fn instruction_test_scrolling_lowres() {
let mut x = Chip8Computer::new();
x.video_memory = build_checkerboard();
Chip8CpuInstructions::SRT.execute(&mut x);
Chip8CpuInstructions::SCR.execute(&mut x);
assert_eq!(read_test_result("test_scroll_right_4.asc"), x.dump_video_to_string());
x = Chip8Computer::new();
x.video_memory = build_checkerboard();
Chip8CpuInstructions::SLF.execute(&mut x);
Chip8CpuInstructions::SCL.execute(&mut x);
assert_eq!(read_test_result("test_scroll_left_4.asc"), x.dump_video_to_string());
x = Chip8Computer::new();
x.video_memory = build_checkerboard();
Chip8CpuInstructions::SDN(0x01).execute(&mut x);
Chip8CpuInstructions::SCD(0x01).execute(&mut x);
assert_eq!(read_test_result("test_video_scroll_down_1.asc"), x.dump_video_to_string());
x = Chip8Computer::new();
x.video_memory = build_checkerboard();
Chip8CpuInstructions::SDN(0xA).execute(&mut x);
Chip8CpuInstructions::SCD(0xA).execute(&mut x);
assert_eq!(read_test_result("test_video_scroll_down_10.asc"), x.dump_video_to_string());
}

View File

@ -3,12 +3,14 @@ use gemma::chip8::instructions::Chip8CpuInstructions::*;
use gemma::chip8::quirk_modes::QuirkMode::{Chip8, SChipModern, XOChip};
use gemma::constants::*;
#[derive(Clone)]
struct InstructionTestQuirks {
chip8: Chip8CpuInstructions,
schip: Chip8CpuInstructions,
xochip: Chip8CpuInstructions
}
#[derive(Clone)]
struct InstructionTest {
name: String,
instruction: Chip8CpuInstructions,
@ -23,7 +25,7 @@ fn instructions_encode_decode_tests_with_quirks() {
let it = vec![
InstructionTest {
name: INST_SYS.to_string(),
instruction: Chip8CpuInstructions::SYS(0x123),
instruction: SYS(0x123),
operands: "0x0123".to_string(),
asm: "SYS 0x0123".to_string(),
encoded: 0x0123,
@ -35,7 +37,7 @@ fn instructions_encode_decode_tests_with_quirks() {
},
InstructionTest {
name: INST_CLS.to_string(),
instruction: Chip8CpuInstructions::CLS,
instruction: CLS,
asm: "CLS".to_string(),
operands: "".to_string(),
encoded: 0x00E0,
@ -47,7 +49,7 @@ fn instructions_encode_decode_tests_with_quirks() {
},
InstructionTest {
name: INST_RET.to_string(),
instruction: Chip8CpuInstructions::RET,
instruction: RET,
asm: "RET".to_string(),
operands: "".to_string(),
encoded: 0x00ee,
@ -57,132 +59,235 @@ fn instructions_encode_decode_tests_with_quirks() {
xochip: RET
}
},
InstructionTest {
name: INST_JPA.to_string(),
instruction: JPA(0x234),
asm: "JPA 0x0234".to_string(),
encoded: 0xb234,
operands: "0x0234".to_string(),
quirks: InstructionTestQuirks {
chip8: JPA(0x0234),
schip: JPA(0x0234),
xochip: JPA(0x0234)
}
},
InstructionTest {
name: INST_JPX.to_string(),
instruction: Chip8CpuInstructions::JPX(0x1, 0xab),
instruction: JPX(0x1, 0xab),
operands: "0x01, 0x01ab".to_string(),
asm: "JPX 0x01, 0x01ab".to_string(),
encoded: 0,
encoded: 0xb1ab,
quirks: InstructionTestQuirks {
chip8: XXXXERRORINSTRUCTION,
schip: JPX(0x1, 0xab),
xochip: XXXXERRORINSTRUCTION,
},
}
/*
,
},
InstructionTest {
name: INST_CALL.to_string(),
instruction: Chip8CpuInstructions::CALL(0x123),
instruction: CALL(0x123),
asm: "CALL 0x0123".to_string(),
encoded: 0x2123,
operands: "0x0123".to_string()
operands: "0x0123".to_string(),
quirks: InstructionTestQuirks {
chip8: CALL(0x123),
schip: CALL(0x123),
xochip: CALL(0x123),
}
},
InstructionTest {
name: INST_DRW.to_string(),
instruction: Chip8CpuInstructions::DRW(0x01, 0x02, 0x03),
instruction: DRW(0x01, 0x02, 0x03),
operands: "0x01, 0x02, 0x03".to_string(),
asm: "DRW 0x01, 0x02, 0x03".to_string(),
encoded: 0xd123
encoded: 0xd123,
quirks: InstructionTestQuirks {
chip8: DRW(0x1, 0x2, 0x3),
schip: DRW(0x1, 0x2, 0x3),
xochip: DRW(0x1, 0x2, 0x3)
}
},
InstructionTest {
name: INST_JPI.to_string(),
instruction: Chip8CpuInstructions::JPI(0x321),
instruction: JPI(0x321),
operands: "0x0321".to_string(),
asm: "JPI 0x0321".to_string(),
encoded: 0xb321
encoded: 0xb321,
quirks: InstructionTestQuirks {
chip8: JPI(0x321),
schip: XXXXERRORINSTRUCTION,
xochip: JPI(0x321)
}
},
InstructionTest {
name: INST_SDN.to_string(),
instruction: Chip8CpuInstructions::SDN(0x01),
name: INST_SCD.to_string(),
instruction: SCD(0x01),
operands: "0x01".to_string(),
asm: "SDN 0x01".to_string(),
encoded: 0x00c1
asm: "SCD 0x01".to_string(),
encoded: 0x00c1,
quirks: InstructionTestQuirks {
chip8: XXXXERRORINSTRUCTION,
schip: SCD(0x1),
xochip: SCD(0x1)
}
},
InstructionTest {
name: INST_SRT.to_string(),
instruction: Chip8CpuInstructions::SRT,
name: INST_SCR.to_string(),
instruction: Chip8CpuInstructions::SCR,
operands: "".to_string(),
asm: "SRT".to_string(),
encoded: 0x00FB
asm: "SCR".to_string(),
encoded: 0x00FB,
quirks: InstructionTestQuirks {
chip8: XXXXERRORINSTRUCTION,
schip: SCR,
xochip: SCR
}
},
InstructionTest {
name: INST_SLF.to_string(),
instruction: Chip8CpuInstructions::SLF,
name: INST_SCL.to_string(),
instruction: SCL,
operands: "".to_string(),
asm: "SLF".to_string(),
asm: "SCL".to_string(),
encoded: 0x00FC,
quirks: InstructionTestQuirks {
chip8: XXXXERRORINSTRUCTION,
schip: SCL,
xochip: SCL
}
},
InstructionTest {
name: INST_EXIT.to_string(),
instruction: Chip8CpuInstructions::EXIT,
instruction: EXIT,
operands: "".to_string(),
asm: "EXIT".to_string(),
encoded: 0x00FD,
quirks: InstructionTestQuirks {
chip8: XXXXERRORINSTRUCTION,
schip: EXIT,
xochip: EXIT
}
},
InstructionTest {
name: INST_DIS.to_string(),
instruction: Chip8CpuInstructions::DIS,
name: INST_LOW.to_string(),
instruction: LOW,
operands: "".to_string(),
asm: "DIS".to_string(),
asm: "LOW".to_string(),
encoded: 0x00FE,
quirks: InstructionTestQuirks {
chip8: XXXXERRORINSTRUCTION,
schip: LOW,
xochip: LOW,
}
},
InstructionTest {
name: INST_ENA.to_string(),
instruction: Chip8CpuInstructions::ENA,
name: INST_HIGH.to_string(),
instruction: HIGH,
operands: "".to_string(),
asm: "ENA".to_string(),
asm: "HIGH".to_string(),
encoded: 0x00FF,
quirks: InstructionTestQuirks {
chip8: XXXXERRORINSTRUCTION,
schip: HIGH,
xochip: HIGH
}
},
InstructionTest {
name: INST_SEX.to_string(),
instruction: Chip8CpuInstructions::SEX(0x01, 0xfa),
operands: "0x01, 0xfa".to_string(),
asm: "SEX 0x01, 0xfa".to_string(),
encoded: 0x32fa,
encoded: 0x31fa,
quirks: InstructionTestQuirks {
chip8: Chip8CpuInstructions::SEX(0x1, 0xfa),
schip: Chip8CpuInstructions::SEX(0x1, 0xfa),
xochip: Chip8CpuInstructions::SEX(0x1, 0xfa)
},
},
InstructionTest {
name: INST_SNEB.to_string(),
instruction: Chip8CpuInstructions::SNEB(0x01, 0xab),
operands: "0x01, 0xab".to_string(),
asm: "SNEB 0x01, 0xab".to_string(),
encoded: 0x41ab,
quirks: InstructionTestQuirks {
chip8: SNEB(0x01, 0xab),
schip: SNEB(0x01, 0xab),
xochip: SNEB(0x01, 0xab),
},
},
InstructionTest {
name: INST_SEY.to_string(),
instruction: Chip8CpuInstructions::SEY(0x1, 0x2),
operands: "0x1, 0x2".to_string(),
asm: "SEY 0x1, 0x2".to_string(),
encoded: 0x5120
encoded: 0x5120,
quirks: InstructionTestQuirks {
chip8: SEY(0x1, 0x2),
schip: SEY(0x1, 0x2),
xochip: SEY(0x1, 0x2)
}
},
InstructionTest {
name: INST_LDR.to_string(),
instruction: Chip8CpuInstructions::LDR(0xa, 0xbe),
instruction: LDR(0xa, 0xbe),
operands: "0x0a, 0xbe".to_string(),
asm: "LDR 0x0a, 0xbe".to_string(),
encoded: 0x6abe,
quirks: InstructionTestQuirks {
chip8: LDR(0xa, 0xbe),
schip: LDR(0xa, 0xbe),
xochip: LDR(0xa, 0xbe)
},
},
InstructionTest {
name: INST_ADD.to_string(),
instruction: Chip8CpuInstructions::ADD(0x01, 0xab),
operands: "0x01, 0xab".to_string(),
asm: "ADD 0x01, 0xab".to_string(),
encoded: 0x71ab
encoded: 0x71ab,
quirks: InstructionTestQuirks {
chip8: ADD(0x01, 0xab),
schip: ADD(0x01, 0xab),
xochip: ADD(0x01, 0xab),
},
},
InstructionTest {
name: INST_LDRK.to_string(),
instruction: Chip8CpuInstructions::LDRK(0x6),
operands: "0x06".to_string(),
asm: "LDRK 0x06".to_string(),
encoded: 0xF60A,
quirks: InstructionTestQuirks {
chip8: Chip8CpuInstructions::LDRK(0x6),
schip: Chip8CpuInstructions::LDRK(0x6),
xochip: Chip8CpuInstructions::LDRK(0x6),
},
},
];
for current in it {
let instruction = current.clone().instruction;
let asm = Chip8CpuInstructions::from_str(&current.asm);
let as_chip8 = Chip8CpuInstructions::decode(current.encoded, &Chip8);
let quirks_chip8 = current.quirks.chip8;
let as_schip = Chip8CpuInstructions::decode(current.encoded, &SChipModern);
let quirks_schip = current.quirks.schip;
let as_xochip = Chip8CpuInstructions::decode(current.encoded, &XOChip);
let quirks_xochip = current.quirks.xochip;
// ** CONVERSION **
// -> Integer to Instruction
assert!(matches!(Chip8CpuInstructions::decode(current.encoded, &Chip8), i));
// -> Instruction to Integer
println!("TESTING INSTRUCTION TO INTEGER FOR {:?} / {:04x} {:04x}", current.instruction, current.encoded, instruction.encode());
assert_eq!(current.encoded, instruction.encode());
// -> Instruction to String
assert_eq!(instruction.to_string(), current.asm);
assert_eq!(instruction.operands(), current.operands);
assert_eq!(current.instruction.name(), current.name);
// -> String to Instruction
assert!(matches!(Chip8CpuInstructions::from_str(&current.name), asm));
// ** QUIRKS **
assert!(matches!(as_chip8, quirks_chip8));
assert!(matches!(as_schip, quirks_schip));
assert!(matches!(as_xochip, quirks_xochip));
}
}
/*
InstructionTest {
name: INST_LDRY.to_string(),
instruction: Chip8CpuInstructions::LDR_Y(0x1, 0x2),
@ -301,14 +406,7 @@ fn instructions_encode_decode_tests_with_quirks() {
operands: "0x04".to_string(),
asm: "LDRD 0x04".to_string(),
encoded: 0xF407
},
InstructionTest {
name: INST_LDRK.to_string(),
instruction: Chip8CpuInstructions::LDRK(0x6),
operands: "0x06".to_string(),
asm: "LDRK 0x06".to_string(),
encoded: 0xF60A
},
}
InstructionTest {
name: INST_LDD.to_string(),
instruction: Chip8CpuInstructions::LDD(0x02),
@ -372,28 +470,18 @@ fn instructions_encode_decode_tests_with_quirks() {
asm: "STR 0x0a".to_string(),
encoded: 0xF000
}
InstructionTest {
name: INST_JPA.to_string(),
instruction: JPA(0x234),
asm: "JPA 0x0234".to_string(),
encoded: 0xb234,
operands: "0x0234".to_string(),
quirks: InstructionTestQuirks {
chip8: JPA(0x0234),
schip: JPA(0x0234),
xochip: JPA(0x0234)
}
},
*/
];
for current in it {
assert_eq!(current.instruction.name(), current.name);
let i = current.instruction;
assert!(matches!(Chip8CpuInstructions::decode(current.encoded, &Chip8), i));
assert_eq!(i.to_string(), current.asm);
let asm = Chip8CpuInstructions::from_str(&current.asm);
assert_eq!(i.to_string(), asm.to_string());
assert_eq!(i.operands(), current.operands);
// test quirks
let as_chip8 = Chip8CpuInstructions::decode(current.encoded, &Chip8);
let quirks_chip8 = current.quirks.chip8;
let as_schip = Chip8CpuInstructions::decode(current.encoded, &SChipModern);
let quirks_schip = current.quirks.schip;
let as_xochip = Chip8CpuInstructions::decode(current.encoded, &XOChip);
let quirks_xochip = current.quirks.xochip;
assert!(matches!(as_chip8, quirks_chip8));
assert!(matches!(as_schip, quirks_schip));
assert!(matches!(as_xochip, quirks_xochip));
}
}

View File

@ -11,7 +11,7 @@ use gemma::chip8::system_memory::Chip8SystemMemory;
use crate::ImGuiUiState;
use crate::support::gui_file_list::GuiFileList;
const ROM_ROOT: &str = "/home/tmerritt/Projects/chip8_toy/resources/roms";
const ROM_ROOT: &str = "resources/roms";
pub struct GemmaImguiSupport {}
@ -21,7 +21,7 @@ const CELL_HEIGHT: i32 = 5i32;
impl GemmaImguiSupport {
pub fn keypad_display(system_to_display: &Chip8Computer, ui: &Ui) {
ui.window("Keypad".to_string())
.size([100.0, 100.0], Condition::FirstUseEver)
.position([100.0, 640.0], Condition::FirstUseEver)
.build(|| {
for row in CHIP8_KEYBOARD {
for key in row {
@ -46,11 +46,8 @@ impl GemmaImguiSupport {
let cell_width = ((draw_area_size[0] as i32 / width) * 6) / 10;
let cell_height = ((draw_area_size[1] as i32 / height) * 6) / 10;
ui.window(format!("Display {cell_width}x{cell_height}"))
.size([300.0, 300.0], Condition::Once)
.build(|| {
let origin = ui.cursor_pos();
let fg = ui.get_window_draw_list();
let fg = ui.get_foreground_draw_list();
if system_to_control.video_memory.is_highres() {
// ui.text("High Def Video here");
for current_row in 0..=height {
@ -87,12 +84,11 @@ impl GemmaImguiSupport {
}
}
}
});
}
pub fn system_controls(system_to_control: &mut Chip8ComputerManager, gui_state: &mut ImGuiUiState, ui: &Ui) {
// let mut state: Chip8Computer = system_to_control;
ui.window("!!!! CONTROLS !!!!")
.size([345.0, 200.0], Condition::FirstUseEver)
.position([100.0, 640.0], Condition::FirstUseEver)
.build(|| {
/* System Step Counter */
ui.text(format!("Step {:04x}", system_to_control.num_cycles()).as_str());
@ -155,7 +151,7 @@ impl GemmaImguiSupport {
pub fn registers_view(system: &Chip8Computer, ui: &Ui) {
ui.window("Registers")
.size([400.0, 500.0], Condition::FirstUseEver)
.position([100.0, 640.0], Condition::FirstUseEver)
.build(|| {
ui.text("Registers");
for i in 1..0x10 {
@ -179,7 +175,7 @@ impl GemmaImguiSupport {
let rows = position.0;
let cols = position.1;
ui.window("System Memory")
.size([400.0, 300.0], Condition::FirstUseEver)
.position([100.0, 640.0], Condition::FirstUseEver)
.build(|| {
let mut current_x_hover: i32 = 0;
let mut current_y_hover: i32 = 0;

View File

@ -13,6 +13,7 @@ impl GuiFileList {
let mut known_files: Vec<OsString> = vec![];
println!("STARTING AT {:?}", std::env::current_dir());
for entry in read_dir(root.as_path()).unwrap() {
known_files.push(entry.unwrap().file_name());
}

View File

@ -31,6 +31,7 @@ fn main() {
}
}
#[cfg(test)]
mod test {
use pest::Parser;
use crate::{Chip8AsmParser, Rule};

View File

@ -80,13 +80,3 @@ fn main() {
}
}
}
mod test {
#[test]
fn smoke() { assert!(true); }
#[test]
fn assemble_test_file() {
}
}

View File

@ -1,3 +0,0 @@
#[test]
fn smoke() { assert!(true) }